Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle no_entry and no_exit turn restrictions #4241

Closed
5 tasks
daniel-j-h opened this issue Jul 6, 2017 · 4 comments · Fixed by #5988
Closed
5 tasks

Handle no_entry and no_exit turn restrictions #4241

daniel-j-h opened this issue Jul 6, 2017 · 4 comments · Fixed by #5988

Comments

@daniel-j-h
Copy link
Member

Currently we only handle (fromWayId, viaNodeId, toWayId) turn restrictions and work for handling way-vias is in progress #2681.

What we don't consider at all is no_entry and no_exit which can have multiple from and to ways, respectively - see spec: http://wiki.openstreetmap.org/wiki/Relation:restriction#Members

What we should do is

  • detect no_entry and no_exit turn restrictions
  • insert multiple (from, via, to) turn restrictions for all from and for all to ways
  • add cucumber tests for no_entry and no_exit (might require updating support code)
  • update taginfo.json
  • update changelog
@MoKob MoKob self-assigned this Jul 6, 2017
@MoKob
Copy link

MoKob commented Jul 7, 2017

@daniel-j-h I just checked taginfo, it seems like there are 5 tags using no_entry, none for no_exit. I guess we can skip on supporting these?

@daniel-j-h
Copy link
Member Author

You need to check for relation=no_entry/no_exit

given that these transform to multiple simple turn restrictions I would love to have them in.

@daniel-j-h
Copy link
Member Author

@MoKob with your turn restriction work merged into master what's your assessment here? What specifically needs to be done and can we simply add multiple "simple" turn restrictions for these tags?

@MoKob
Copy link

MoKob commented Aug 11, 2017

@daniel-j-h yes, we would need to translate the single restriction into multiple ones to allow this.
It requires:

  • translating a restriction into multiple node restrictions

    • adjust this to not handle single from/via/to but multiple
    • output multiple node-restrictions for all n*m combinations
  • hand off multiple restrictions here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants