Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out LuaJIT for good #2955

Closed
3 tasks done
daniel-j-h opened this issue Sep 27, 2016 · 2 comments
Closed
3 tasks done

Rip out LuaJIT for good #2955

daniel-j-h opened this issue Sep 27, 2016 · 2 comments

Comments

@daniel-j-h
Copy link
Member

daniel-j-h commented Sep 27, 2016

At the moment our build system happily searches for LuaJIT and uses it when for example no other Lua installation is found or works with Luabind. This is dangerous since LuaJIT is not a first-class citizen in OSRM: we never test with it, don't run any setups with it and users are reporting crashes on various platforms and setups. Let's rip it out for good, since Lua/Luabind is already a pain in itself.

Instead of justifying a (potential?) performance improvement during extraction using LuaJIT we rather should explore for example not context switching between Lua and C++ on every Node / Way: #1777.

  • no longer try to use it in CMakeLists.txt
  • do not test if Luabind compiles with it in cmake/check_luabind.cmake
  • remove CMake module searching for Luajit cmake/FindLuaJIT.cmake
@springmeyer
Copy link
Contributor

👍

@MoKob
Copy link

MoKob commented Sep 28, 2016

Landed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants