Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError in meshgrid #8252

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Fix TypeError in meshgrid #8252

merged 4 commits into from
Dec 4, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Dec 3, 2024

Fixes #8251

Remove indexing="ij" will not affect anything since it's default behavior in torch.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Dec 3, 2024

/build

@KumoLiu KumoLiu requested review from ericspod and Nic-Ma December 3, 2024 05:12
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Dec 3, 2024

/build

1 similar comment
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Dec 3, 2024

/build

@KumoLiu KumoLiu enabled auto-merge (squash) December 3, 2024 16:03
@KumoLiu KumoLiu requested a review from mingxin-zheng December 4, 2024 03:00
Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix for older version of torch.meshgrid looks good to me!

@KumoLiu KumoLiu merged commit e604d18 into Project-MONAI:dev Dec 4, 2024
28 checks passed
@KumoLiu KumoLiu deleted the fix-meshgrid branch December 4, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: meshgrid() got an unexpected keyword argument 'indexing'
2 participants