Removed CPU randn() from schedulers #8145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Fomitchev <[email protected]>
ericspod
approved these changes
Oct 12, 2024
|
@ericspod : the pipeline fails on checks not related to the changes that I made: |
|
Hi @borisfom the checks were done with a version of mypy that dropped about 9 hours ago so it's possible we have a version issue here. @KumoLiu some of the issues are with MAISI code and a few other places, should we pin mypy version for now to something less than 1.12? I had a go a fixing the issues quickly but it became the usual thing in that more issues came up if I tried fixing one. |
|
/build |
KumoLiu
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes performance issued due to extra CPU/GPU sync:
https://nvbugswb.nvidia.com/NvBugs5/SWBug.aspx?bugid=4904446&cmtNo=