-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks for monai bundles after download and warn if incompatible #7938
Add checks for monai bundles after download and warn if incompatible #7938
Conversation
…s incompatible Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Co-authored-by: YunLiu <[email protected]> Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
/build |
Do you think we can add a logging information mentioned that the version we download is not the latest bundle version when we automatically select a version match the package version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one remaining comment, other parts looks good to me, thanks!
Sure let me change it then |
Signed-off-by: Mingxin Zheng <[email protected]>
Latest commit (1ce127d) should address the last comment. Thanks @KumoLiu : Hardcode the version to 1.2 to trigger compatibility check, and download non-latest version.
|
Signed-off-by: Mingxin Zheng <[email protected]>
/build |
Fixes #7930 .
Description
Check the monai version in metadata JSON and warn if the version is newer than the package being used.
Demonstration
Warning when the version is hardcoded to 1.2 from monaihosting
Auto select version if the download src is from NGC
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.