Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6676 port generative networks autoencoderkl #7260

Merged
merged 14 commits into from
Dec 5, 2023
Merged

6676 port generative networks autoencoderkl #7260

merged 14 commits into from
Dec 5, 2023

Conversation

marksgraham
Copy link
Contributor

Partially fixes #6676

Description

Implements the AutoencoderKL network from MONAI Generative.

NB this network is subject to a planned refactor once the porting is complete, see here.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@marksgraham
Adds network and tests
d99044b
@marksgraham
Mypy fixes
9d16b48 
Signed-off-by: Mark Graham <[email protected]>
@marksgraham
Fix doc
fbfd8f5 
Signed-off-by: Mark Graham <[email protected]>
@ericspod
Copy link
Member

Looks good to me since we've already used this code a lot and reviewed it elsewhere. The fails are from the arguments for checkpoint being different in older versions of Pytorch. We could define a separate checkpoint function which adapts the interface depending on the version of Pytorch we're dealing with. I see checkpoint being used in other parts of MONAI with this argument so it seems it's not well tested.

@ericspod ericspod mentioned this pull request Nov 28, 2023
Closed
KumoLiu
KumoLiu reviewed Nov 29, 2023
View reviewed changes
monai/networks/nets/autoencoderkl.py Outdated Show resolved Hide resolved
monai/networks/nets/autoencoderkl.py Show resolved Hide resolved
monai/networks/nets/autoencoderkl.py Outdated Show resolved Hide resolved
monai/networks/nets/autoencoderkl.py Outdated Show resolved Hide resolved
marksgraham and others added 8 commits November 29, 2023 08:27
@marksgraham @ericspod
Update monai/networks/nets/autoencoderkl.py
cd60374 
Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
@marksgraham @KumoLiu
Update monai/networks/nets/autoencoderkl.py
b9798b3 
Co-authored-by: YunLiu <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
@marksgraham
Rename num_channels to channels
a6bb925
@marksgraham
Use optional import
4caafe0
@marksgraham
DCO Remediation Commit for Mark Graham <[email protected]>
2bf0169 
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: d99044b
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: a6bb925
I, Mark Graham <[email protected]>, hereby add my Signed-off-by to this commit: 4caafe0

Signed-off-by: Mark Graham <[email protected]>
@marksgraham
Updates use_checkpointing to use_checkpoint
6a9f657 
Signed-off-by: Mark Graham <[email protected]>
@marksgraham
Checkpoint fixes
3e7dc6c 
Signed-off-by: Mark Graham <[email protected]>
@marksgraham
Change decorator order so test skipping works
d4302d9 
Signed-off-by: Mark Graham <[email protected]>
@KumoLiu KumoLiu requested a review from Nic-Ma November 29, 2023 15:37
@marksgraham
Version fix
6817179 
Signed-off-by: Mark Graham <[email protected]>
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Dec 1, 2023

@KumoLiu please create a seperate branch for Generative AI development, for example "gen-ai-dev", then let's merge the PR to that branch as we discussed.

Thanks.

@KumoLiu
Copy link
Contributor

KumoLiu commented Dec 1, 2023

please create a seperate branch for Generative AI development, for example "gen-ai-dev", then let's merge the PR to that branch as we discussed.

Have created.

@marksgraham marksgraham changed the base branch from dev to gen-ai-dev December 4, 2023 12:15
@marksgraham
Copy link
Contributor Author

please create a seperate branch for Generative AI development, for example "gen-ai-dev", then let's merge the PR to that branch as we discussed.

Have created.

Hi @Nic-Ma - have changed the PR to merge to gen-ai-dev

@KumoLiu KumoLiu requested a review from ericspod December 5, 2023 08:47
@KumoLiu
Copy link
Contributor

KumoLiu commented Dec 5, 2023

/build

@KumoLiu
Copy link
Contributor

KumoLiu commented Dec 5, 2023

Hi @ericspod, and @Nic-Ma, do you have any other concerns on this PR?

@KumoLiu KumoLiu mentioned this pull request Dec 5, 2023
Merged
7 tasks
@ericspod
Copy link
Member

ericspod commented Dec 5, 2023

Looks good, we shall consider refactorings later once the porting is complete.

@marksgraham marksgraham merged commit fac754d into Project-MONAI:gen-ai-dev Dec 5, 2023
28 checks passed
marksgraham added a commit to marksgraham/MONAI that referenced this pull request Jan 30, 2024
@marksgraham @ericspod @KumoLiu
6676 port generative networks autoencoderkl (Project-MONAI#7260)
039ee21 
Partially fixes Project-MONAI#6676

### Description
Implements the AutoencoderKL network from MONAI Generative.

NB this network is subject to a planned refactor once the porting is
complete, [see
here](Project-MONAI#7227).

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Mark Graham <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]>
Co-authored-by: YunLiu <[email protected]>
Signed-off-by: Mark Graham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu left review comments

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move MONAI Generative into core
4 participants
@marksgraham @ericspod @Nic-Ma @KumoLiu