Replace single quotation marks with double quotation marks to install… #7234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericspod
reviewed
Nov 15, 2023
|
You do need to fix the DCO issue however, if you accept suggested changes in Github it isn't done correctly I think. I would suggest following the instructions for doing a remediation commit. |
auto-merge was automatically disabled
November 16, 2023 07:24
Head branch was pushed to by a user without write access
ytl0623
force-pushed
the
fix-issue-6118
branch
2 times, most recently
from
f2d7952 to
6651ce1
Compare
… MONAI with all dependencies on Windows Fixes Project-MONAI#6118 Signed-off-by: ytl0623 <[email protected]>
ytl0623
force-pushed
the
fix-issue-6118
branch
from
6651ce1 to
9901968
Compare
|
Hi @ericspod, I have solved the DCO problem. Can you please help me review and merge it again? Thank you! |
|
/build |
marksgraham
pushed a commit
to marksgraham/MONAI
that referenced
this pull request
Jan 30, 2024
Project-MONAI#7234) … MONAI with all dependencies on Windows Fixes Project-MONAI#6118 ### Description The Windows shell doesn't recognize single quotes to delimit a string at all, so on Windows you'll need to use double quotes. It's the same command no matter which type of quotes you use; after the shell does its processing, the argument is passed to pip with the quotation marks already removed. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: ytl0623 <[email protected]> Signed-off-by: Mark Graham <[email protected]>
juampatronics
pushed a commit
to juampatronics/MONAI
that referenced
this pull request
Mar 25, 2024
Project-MONAI#7234) … MONAI with all dependencies on Windows Fixes Project-MONAI#6118 ### Description The Windows shell doesn't recognize single quotes to delimit a string at all, so on Windows you'll need to use double quotes. It's the same command no matter which type of quotes you use; after the shell does its processing, the argument is passed to pip with the quotation marks already removed. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: ytl0623 <[email protected]> Signed-off-by: Juan Pablo de la Cruz Gutiérrez <[email protected]>
Yu0610
pushed a commit
to Yu0610/MONAI
that referenced
this pull request
Apr 11, 2024
Project-MONAI#7234) … MONAI with all dependencies on Windows Fixes Project-MONAI#6118 ### Description The Windows shell doesn't recognize single quotes to delimit a string at all, so on Windows you'll need to use double quotes. It's the same command no matter which type of quotes you use; after the shell does its processing, the argument is passed to pip with the quotation marks already removed. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: ytl0623 <[email protected]> Signed-off-by: Yu0610 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… MONAI with all dependencies on Windows
Fixes #6118
Description
The Windows shell doesn't recognize single quotes to delimit a string at all, so on Windows you'll need to use double quotes. It's the same command no matter which type of quotes you use; after the shell does its processing, the argument is passed to pip with the quotation marks already removed.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.