Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing SegmentDescription in PydicomReader #6937

Merged
merged 11 commits into from
Sep 4, 2023
Merged

Fix missing SegmentDescription in PydicomReader #6937

merged 11 commits into from
Sep 4, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 4, 2023

Fixes #6928.

Description

SegmentDescription is optional, https://dicom.innolitics.com/ciods/segmentation/segmentation-image/00620002/00620006, so try SegmentLabel first.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#6928
64c3321 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
minor fix
edd33bf 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
minor fix
1493b0d 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
try SegmentLabel first
a28a423 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
fix flake8
a9cbd49 
Signed-off-by: KumoLiu <[email protected]>
wyli
wyli reviewed Sep 4, 2023
View reviewed changes
monai/data/image_reader.py Outdated Show resolved Hide resolved
@wyli
Copy link
Contributor

wyli commented Sep 4, 2023

/build

@wyli wyli enabled auto-merge (squash) September 4, 2023 12:03
ericspod
ericspod reviewed Sep 4, 2023
View reviewed changes
monai/data/image_reader.py Outdated Show resolved Hide resolved
@wyli wyli disabled auto-merge September 4, 2023 13:01
@KumoLiu
address comments
591351a 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
address comments
a33c329 
Signed-off-by: KumoLiu <[email protected]>
ericspod
ericspod approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wyli
Copy link
Contributor

wyli commented Sep 4, 2023

/build

@wyli wyli enabled auto-merge (squash) September 4, 2023 13:34
@Nic-Ma Nic-Ma requested a review from binliunls September 4, 2023 14:19
@wyli wyli merged commit d876c3f into Project-MONAI:dev Sep 4, 2023
26 of 30 checks passed
@KumoLiu KumoLiu deleted the pydicomreader branch September 5, 2023 02:35
@wyli wyli mentioned this pull request Sep 5, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@ericspod ericspod ericspod approved these changes

@wyli wyli wyli approved these changes

@binliunls binliunls Awaiting requested review from binliunls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get an error when reading dicom segmentation
4 participants
@KumoLiu @wyli @ericspod @Nic-Ma