Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4103 enhances surface Dice to use subvoxel borders #6681

Merged
merged 13 commits into from
Jul 5, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jul 1, 2023

Fixes #4103

Description

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli marked this pull request as ready for review July 1, 2023 17:16
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 4103-surface-based-elements branch from 52eb0f5 to 831c940 Compare July 1, 2023 17:27
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wyli . I checked the changes and this PR looks good to me. Could you address a few minor issues?

@wyli wyli force-pushed the 4103-surface-based-elements branch from 993325c to c774e92 Compare July 4, 2023 10:06
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 4103-surface-based-elements branch from 93e6c0c to 046b27a Compare July 4, 2023 10:10
@wyli
Copy link
Contributor Author

wyli commented Jul 4, 2023

Thanks @wyli . I checked the changes and this PR looks good to me. Could you address a few minor issues?

thanks, the comments are addressed, I also update to use the pytorch APIs as much as possible instead of converting everything into numpy arrays.

@Nic-Ma Nic-Ma requested a review from yiheng-wang-nv July 4, 2023 13:01
@wyli
Copy link
Contributor Author

wyli commented Jul 5, 2023

/build

@wyli wyli merged commit 922b11e into Project-MONAI:dev Jul 5, 2023
@wyli wyli deleted the 4103-surface-based-elements branch July 5, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extensions of the surface-based metric
2 participants