-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend SurfaceDiceMetric for 3D images #6549
Conversation
Signed-off-by: Bryn Lloyd <[email protected]>
/black |
Signed-off-by: Bryn Lloyd <[email protected]>
Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Bryn Lloyd <[email protected]>
Hi @dyollb, thanks for the PR! since you are looking at these components... would you be interested in fixing a related documentation issue #5906? I think to close the issue we just replace For the 3D option, it'll be very useful to clarify that this implementation is different from the deepmind's in terms of the voxel surface boundaries #4103, perhaps we include this URL |
Signed-off-by: Bryn Lloyd <[email protected]>
Thanks @wyli. I adapted the docstring accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I'll fix the style error and merge this soon..
Signed-off-by: Wenqi Li <[email protected]>
/build |
Description
This PR extends the
SurfaceDiceMetric
for 3D images. The implementation already uses generic functions to obtain the boundary edges and compute the distance, the extension just[B,C,W,H]
).TestAllSurfaceDiceMetrics.test_tolerance_euclidean_distance_3d
fixes #5906
mentioning #4103
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.