Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MONAILabel-related bugs in dtype conversion and inverse of Spacing #6315

Merged
merged 5 commits into from
Apr 11, 2023

Conversation

liamchalcroft
Copy link
Contributor

Fixes issues relating to dtype and src_affine in inverse of spatial transforms. Issue found to occur when inverse for a given function is required many times, e.g. for iterative updates in interactive segmentation. Related issue #6314

I, Liam Chalcroft <[email protected]>, hereby add my Signed-off-by to this commit: 77c41a8
I, Liam Chalcroft <[email protected]>, hereby add my Signed-off-by to this commit: 7dd6146
I, Liam Chalcroft <[email protected]>, hereby add my Signed-off-by to this commit: f06d0e5

Signed-off-by: Liam Chalcroft <[email protected]>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good to me, I'll add the unit tests before merging into dev

@wyli wyli changed the base branch from dev to auto-update April 11, 2023 07:47
@wyli wyli merged commit 768964b into Project-MONAI:auto-update Apr 11, 2023
wyli added a commit that referenced this pull request Apr 11, 2023
Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request Apr 11, 2023
Signed-off-by: monai-bot <[email protected]>

(closing #6318 closing #6319 auto3dseg)
(closing #6314 closing #6315 dtype conversion)
(closing #6326 closing #6329 metatensor clone)
(including a workaround for #6311)

---------

Signed-off-by: monai-bot <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Liam Chalcroft <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Co-authored-by: Mingxin Zheng <[email protected]>
Co-authored-by: Liam Chalcroft <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
Co-authored-by: YunLiu <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants