-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unused arg in SlidingPatchWSIDataset
#6047
Conversation
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
/build |
The dev on this WSI dataset class is great! |
Hi @tangy5, absolutely! We're going to address that soon with wsi sliding window splitter. Will keep you updated. |
### Description This PR removes `map_level` from `SlidingPatchWSIDataset`, which seems to be left from the previous changes and has not used anywhere. Also it updates the outdated docstring. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] In-line docstrings updated. --------- Signed-off-by: Behrooz <[email protected]>
Off-topic, but what is the status on a
|
Hi @siemdejong, perhaps you could use this MONAI/monai/inferers/splitter.py Line 307 in 4743945
|
Thanks @KumoLiu! I was hoping for a solution that doesn't require Mostly because I would prefer having a mappable Would this be something that could be easily added? |
Description
This PR removes
map_level
fromSlidingPatchWSIDataset
, which seems to be left from the previous changes and has not used anywhere. Also it updates the outdated docstring.Types of changes