Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5762 pprint head and tail bundle script #5969

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Feb 9, 2023

Signed-off-by: Wenqi Li [email protected]

Fixes #5762

Description

limiting the number of printing lines

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli changed the title 5762 pprint head and tail 5762 pprint head and tail bundle script Feb 9, 2023
@wyli wyli requested a review from SachidanandAlle February 9, 2023 23:40
Signed-off-by: Wenqi Li <[email protected]>
Copy link
Contributor

@SachidanandAlle SachidanandAlle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyli wyli marked this pull request as ready for review February 10, 2023 00:06
@wyli
Copy link
Contributor Author

wyli commented Feb 10, 2023

/build

@wyli wyli enabled auto-merge February 10, 2023 00:08
@wyli wyli force-pushed the 5762-long-list-print branch from b816f6d to 5a0d83d Compare February 10, 2023 00:14
@wyli
Copy link
Contributor Author

wyli commented Feb 10, 2023

/build

@wyli wyli disabled auto-merge February 10, 2023 00:15
monai/utils/misc.py Show resolved Hide resolved
@wyli wyli enabled auto-merge (squash) February 10, 2023 06:07
@wyli wyli merged commit 5657b8f into Project-MONAI:dev Feb 10, 2023
wyli added a commit to wyli/MONAI that referenced this pull request Feb 13, 2023
Signed-off-by: Wenqi Li <[email protected]>

Fixes Project-MONAI#5762

### Description

limiting the number of printing lines

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli deleted the 5762-long-list-print branch February 21, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundle script - pprint doesn't take care of long list correctly
4 participants