Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instantiate for object instantiation with attribute path #5866

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Fix instantiate for object instantiation with attribute path #5866

merged 2 commits into from
Jan 18, 2023

Conversation

surajpaib
Copy link
Contributor

@surajpaib surajpaib commented Jan 18, 2023

Fixes #5865

-- also fixes #5868 to unblock premerge

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@surajpaib surajpaib changed the title Fix instantiate for object instantiation with attribute path WIP: Fix instantiate for object instantiation with attribute path Jan 18, 2023
@surajpaib surajpaib marked this pull request as draft January 18, 2023 05:00
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you please signoff the commit with "git commit --signoff" https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work

The flake8 style error is irrelevant, I'll change the style config when merging this PR

@surajpaib surajpaib marked this pull request as ready for review January 18, 2023 15:13
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Contributor

wyli commented Jan 18, 2023

/build

@wyli wyli enabled auto-merge (squash) January 18, 2023 15:18
@Nic-Ma Nic-Ma disabled auto-merge January 18, 2023 15:19
@wyli wyli changed the title WIP: Fix instantiate for object instantiation with attribute path Fix instantiate for object instantiation with attribute path Jan 18, 2023
@wyli wyli enabled auto-merge (squash) January 18, 2023 15:25
@wyli wyli merged commit bdf5e1e into Project-MONAI:dev Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

premerge flake8 MONAI bundle instantiate fails when _target_ contains path attribute
3 participants