Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for device config script #1480

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Fix for device config script #1480

merged 3 commits into from
Jan 21, 2021

Conversation

ericspod
Copy link
Member

Signed-off-by: Eric Kerfoot [email protected]

Description

Fixes an issue with the GPU devide info script which overwrites entries for GPU values if there is more than one GPU. Since the data is stored in a dict the keys have to be unique for each GPU.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Eric Kerfoot <[email protected]>
@ericspod ericspod requested a review from rijobro January 21, 2021 13:09
@ericspod
Copy link
Member Author

/black

@ericspod ericspod merged commit edbad43 into Project-MONAI:master Jan 21, 2021
@ericspod ericspod deleted the deviceconfigscriptfix branch January 21, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants