Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1478 Fix TorchScript issue in AHnet #1479

Merged
merged 3 commits into from
Jan 21, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jan 21, 2021

Fixes #1478 .

Description

This PR fixed the TorchScript issue in AHNet when num_block_psp=0.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 21, 2021

/black

@wyli
Copy link
Contributor

wyli commented Jan 21, 2021

thanks, could you add a test case to cover this change?

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 21, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 21, 2021

Hi @wyli ,

Thanks for your review.
I updated the PR according to your comments.
Could you please help review it again?

Thanks.

@wyli wyli merged commit c9d15f1 into Project-MONAI:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TorchScript can't work for AHNet when num_psp=0
2 participants