Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

909 develop ImageDataset to replace NiftiDataset #1461

Merged
merged 7 commits into from
Jan 18, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jan 18, 2021

Fixes #909 .

Description

This PR is the last task for ticket #909 , changed NiftiDataset to ImageDataset.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma changed the title [WIP] 909 develop image dataset 909 develop ImageDataset to replace NiftiDataset Jan 18, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review January 18, 2021 13:54
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 18, 2021

/black

monai-bot and others added 2 commits January 18, 2021 13:57
@Nic-Ma Nic-Ma force-pushed the 909-develop-ImageDataset branch from 223d09b to 65b27b2 Compare January 18, 2021 14:01
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 18, 2021

I will submit another separate PR to update all the related tutorials and examples will this PR merged.

Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 18, 2021

/black

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit d2064e0 into Project-MONAI:master Jan 18, 2021
@Nic-Ma Nic-Ma deleted the 909-develop-ImageDataset branch July 2, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

image data reader and LoadImage transform refactoring
3 participants