Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1404 Fixing a few code performance issues #1423

Merged
merged 6 commits into from
Jan 11, 2021
Merged

1404 Fixing a few code performance issues #1423

merged 6 commits into from
Jan 11, 2021

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 10, 2021

part of #1404.

Description

As discussed in the discussion linked above, these issues were detected using the DeepSource static analyzer tool. These issues were specifically tagged and highlighted for their impact on the performance of MONAI, they are:

  • Pass string format arguments as logging method parameters
  • Remove unnecessary use of comprehension
  • Use literal syntax instead of function calls to create data structure

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Contributor

wyli commented Jan 10, 2021

/integration-test

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! i didn't check if the changes are exhaustive, but the changed ones are good.

@wyli wyli merged commit 3d5554f into Project-MONAI:master Jan 11, 2021
@de-sh de-sh deleted the perf-deepsource branch January 11, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants