Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance _download_from_ngc to support no-prefix or different prefix data #7973

Closed
yiheng-wang-nv opened this issue Aug 1, 2024 · 0 comments · Fixed by #7974
Closed

Enhance _download_from_ngc to support no-prefix or different prefix data #7973

yiheng-wang-nv opened this issue Aug 1, 2024 · 0 comments · Fixed by #7974
Assignees

Comments

@yiheng-wang-nv
Copy link
Contributor

So far, it's alway use the default prefix:

def _download_from_ngc(
    download_path: Path, filename: str, version: str, remove_prefix: str | None, progress: bool
) -> None:
    # ensure prefix is contained
    filename = _add_ngc_prefix(filename)
...

We can make use of _add_ngc_prefix's prefix arg

@yiheng-wang-nv yiheng-wang-nv self-assigned this Aug 1, 2024
@yiheng-wang-nv yiheng-wang-nv changed the title Enhance _download_from_ngc_private to support no-prefix or different prefix data Enhance _download_from_ngc to support no-prefix or different prefix data Aug 1, 2024
@yiheng-wang-nv yiheng-wang-nv mentioned this issue Aug 1, 2024
7 tasks
@KumoLiu KumoLiu closed this as completed in ae5a04d Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant