-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define categories for the MONAI bundle properties #7904
Comments
@mingxueg-nv will start the development based on this proposal. Thanks. |
A suggestion, supported_apps also provide a version, like |
I'm good with adding more optional properties to the metadata for bundles. This is the place I feel we can put a lot of configuration and meta information which the model zoo and other tools can use to better understand how to use a bundle. If Also related on the changes to the schema which can incorporate what we want to add to the metadata format: #7409 |
Hi @ericspod , thanks for the suggestions. I agree that we can push the schema changes PR (#7409 ) forward, and then enable the |
I have modified #7409 to include |
Updates: we already have a new schema in MONAI, and MONAI model zoo enables properties check if a bundle uses the new schema and provide the corresponding properties list. So far, the default setting is still to check MONAI's default properties. For each app: |
Hi @SachidanandAlle @tangy5 , for monai label, could you provide some information here? Thanks! |
Hi All,
Currently, we defined all the required bundle properties in 1 file: https://github.com/Project-MONAI/MONAI/blob/dev/monai/bundle/properties.py, which were collected from our MONAI Label, MONAI deploy, NVFlare projects.
But actually, it may not be necessary to require every bundle to provide all these properties. I would like to define different property categories for different applications, then the bundle developer can declare the supported applications in the
metadata.json
. It can help reduce the development effort and limitation for a bundle, and provide more flexibility.Detailed implementation steps:
model-zoo
repo:metadata.json
, for example:"supported_apps": ["monai-label", "nvflare"]
labels
in the bundle list.@ericspod @KumoLiu welcome your discussion here.
Thanks.
The text was updated successfully, but these errors were encountered: