Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated args in OcclusionSensitivity #6610

Closed
wyli opened this issue Jun 13, 2023 · 0 comments · Fixed by #6642
Closed

Remove the deprecated args in OcclusionSensitivity #6610

wyli opened this issue Jun 13, 2023 · 0 comments · Fixed by #6642
Labels
Contribution wanted Feature request good first issue Good for newcomers

Comments

@wyli
Copy link
Contributor

wyli commented Jun 13, 2023

Is your feature request related to a problem? Please describe.
The input arguments marked deprecated since 1.2 could be safely removed as they are not used in the code logic

MONAI/monai/visualize/occlusion_sensitivity.py

Lines 77 to 85 in 4e53af4

@deprecated_arg(
name="pad_val",
since="1.0",
removed="1.2",
msg_suffix="Please use `mode`. For backwards compatibility, use `mode=mean_img`.",
)
@deprecated_arg(name="stride", since="1.0", removed="1.2", msg_suffix="Please use `overlap`.")
@deprecated_arg(name="per_channel", since="1.0", removed="1.2")
@deprecated_arg(name="upsampler", since="1.0", removed="1.2")

When modifying the APIs, would be great to incorporate the relevant feature request #5169
@Nikhil26112 Nikhil26112 mentioned this issue Jun 22, 2023
Merged
wyli pushed a commit that referenced this issue Jun 22, 2023
@Nikhil26112
Update occlusion_sensitivity.py (#6642)
d773ff3 
Fixes #6610 .

### Description
Deprecated code removed
A few sentences describing the changes proposed in this pull request.

---------

Signed-off-by: Nikhil Chauhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contribution wanted Feature request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update occlusion_sensitivity.py Nikhil26112/MONAI
1 participant
@wyli