Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration failure with unmerged ALGO_HASH #6342

Closed
mingxin-zheng opened this issue Apr 12, 2023 · 0 comments · Fixed by #6347
Closed

Integration failure with unmerged ALGO_HASH #6342

mingxin-zheng opened this issue Apr 12, 2023 · 0 comments · Fixed by #6347
Assignees

Comments

@mingxin-zheng
Copy link
Contributor

Describe the bug

https://github.com/Project-MONAI/MONAI/actions/runs/4628332079/jobs/8187277000

The bug is found when Auto3DSeg algorithm_templates in PR review phase. Though it could be introduced by the PR, the cause could also be that the Auto3DSeg ensemble test does not work well on a 8-GPU node, as mentioned in the comment:

https://github.com/Project-MONAI/MONAI/actions/runs/4628332079/jobs/8187277000

We may need to limit the GPUs such as https://github.com/Project-MONAI/research-contributions/blob/de5a8d1454ecd74b488b1e09e5693ddb7fab942e/auto3dseg/tests/test_algo_templates.py#L51

in https://github.com/Project-MONAI/MONAI/blob/dev/tests/test_auto3dseg_ensemble.py

@mingxin-zheng mingxin-zheng self-assigned this Apr 12, 2023
wyli pushed a commit that referenced this issue Apr 12, 2023
…env (#6347)

Fixes #6342  .

### Description

In some testing environment, there are more GPUs than the simulated
dataset image number. This PR is to modify the tests so that it will
generate images enough to finish the testing.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.

---------

Signed-off-by: Mingxin Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant