Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSIReader support for reading by existing power and mpp #6289

Closed
drbeh opened this issue Apr 4, 2023 · 0 comments · Fixed by #6244
Closed

WSIReader support for reading by existing power and mpp #6289

drbeh opened this issue Apr 4, 2023 · 0 comments · Fixed by #6244
Assignees
@drbeh
Milestone
Enhance WSIReader...

Comments

@drbeh
Copy link
Member

drbeh commented Apr 4, 2023 •
edited
Loading

In MONAI Pathology WG, we have discussed about the need for being able to read whole slide images at specific resolution (mpp or magnification) in addition to reading at a specific level.
As discussed in pathology working group, this feature request is part of #4980 that defines the need to read the existing objective power and magnification without interpolating if the requested power or mpp does not exist. We decided to address this part first as the interpolation part requires some discussion on the details.
@drbeh drbeh moved this to 🧐 Under Review in AI in Pathology🔬 Apr 4, 2023
@drbeh drbeh moved this to In Progress in MONAI v1.2 Apr 4, 2023
@drbeh drbeh linked a pull request Apr 4, 2023 that will close this issue
WSIReader read by power and mpp #6244
Merged
6 tasks
@drbeh drbeh mentioned this issue Apr 4, 2023
Merged
6 tasks
@drbeh drbeh self-assigned this Apr 7, 2023
drbeh added a commit that referenced this issue Apr 11, 2023
@drbeh
WSIReader read by power and mpp (#6244)
0a29bc1 
Fixes #6289  

### Description

This PR enable WSIReader to be provided with objective power and
resolution (micron per pixel) to decide which WSI level to load. It also
set absolute and relative tolerances for power and mpp.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Behrooz <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in MONAI v1.2 Apr 11, 2023
@github-project-automation github-project-automation bot moved this from 🧐 Under Review to 💯 Complete in AI in Pathology🔬 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drbeh drbeh

Labels
None yet
Projects
AI in Pathology🔬
Status: 💯 Complete
MONAI v1.2
Status: Done
Milestone
Enhance WSIReader usability and perfo...
Development

Successfully merging a pull request may close this issue.

WSIReader read by power and mpp drbeh/MONAI
1 participant
@drbeh