You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the segmentation performance of the V-Net was a step below other architectures (DynUNet, BasicUnetPlusPlus ...). By looking at the implementation, I noticed that a dropout rate of 50% is systematically applied (hard-coded) in the UpTransition layers of the V-Net, even the user sets dropout_prob to 0.
In monai.networks.nets.vnet : self.dropout = dropout_type(dropout_prob) if dropout_prob is not None else None (l147)
--> self.dropout2 = dropout_type(0.5)(l148)
Expected behavior
It is expected that dropout is set to 0 when dropout_prob is set to 0 in the VNet class.
Fixes#6116
### Description
Converts dropout probability from a Optional float to a Optional tuple
of floats.
### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.
---------
Signed-off-by: Saurav Maheshkar <[email protected]>
First of all thanks for this great repo !
I noticed that the segmentation performance of the V-Net was a step below other architectures (DynUNet, BasicUnetPlusPlus ...). By looking at the implementation, I noticed that a dropout rate of 50% is systematically applied (hard-coded) in the UpTransition layers of the V-Net, even the user sets
dropout_prob
to 0.In monai.networks.nets.vnet :
self.dropout = dropout_type(dropout_prob) if dropout_prob is not None else None
(l147)-->
self.dropout2 = dropout_type(0.5)
(l148)Expected behavior
It is expected that dropout is set to 0 when
dropout_prob
is set to 0 in the VNet class.https://github.com/Project-MONAI/MONAI/blob/dev/monai/networks/nets/vnet.py
The text was updated successfully, but these errors were encountered: