Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows test #5624

Closed
wyli opened this issue Dec 1, 2022 · 1 comment · Fixed by #5814
Closed

windows test #5624

wyli opened this issue Dec 1, 2022 · 1 comment · Fixed by #5814

Comments

@wyli
Copy link
Contributor

wyli commented Dec 1, 2022

the windows test fails (due to some unrelated reason), @wyli can you take a look plz

C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\torch\include\pybind11\detail/common.h(152): warning C4005: 'HAVE_SNPRINTF': macro redefinition C:\hostedtoolcache\windows\Python\3.8.10\x64\include\pyerrors.h(315): note: see previous definition of 'HAVE_SNPRINTF' creating D:\a\MONAI\MONAI\build\lib.win-amd64-3.8 creating D:\a\MONAI\MONAI\build\lib.win-amd64-3.8\monai C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.34.31933\bin\HostX86\x64\link.exe /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\torch\lib /LIBPATH:C:\hostedtoolcache\windows\Python\3.8.10\x64\libs /LIBPATH:C:\hostedtoolcache\windows\Python\3.8.10\x64\PCbuild\amd64 "/LIBPATH:C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.34.31933\ATLMFC\lib\x64" "/LIBPATH:C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.34.31933\lib\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.22621.0\ucrt\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\\lib\10.0.22621.0\\um\x64" c10.lib torch.lib torch_cpu.lib torch_python.lib /EXPORT:PyInit__C D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\ext.obj D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\filtering\bilateral\bilateral.obj D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\filtering\bilateral\bilateralfilter_cpu.obj D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\filtering\bilateral\bilateralfilter_cpu_phl.obj D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\filtering\permutohedral\permutohedral.obj D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\filtering\permutohedral\permutohedral_cpu.obj D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\lltm\lltm_cpu.obj D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\resample\pushpull_cpu.obj /OUT:build\lib.win-amd64-3.8\monai\_C.pyd /IMPLIB:D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\_C.lib /openmp LINK : warning LNK4044: unrecognized option '/openmp'; ignored Creating library D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\_C.lib and object D:\a\MONAI\MONAI\build\temp.win-amd64-3.8\Release\a\MONAI\MONAI\monai\csrc\_C.exp ext.obj : error LNK2001: unresolved external symbol __imp___tls_offset_?init@?1??lazy_init_num_threads@internal@at@@YAXXZ@4_NA ext.obj : error LNK2001: unresolved external symbol __imp___tls_index_?init@?1??lazy_init_num_threads@internal@at@@YAXXZ@4_NA build\lib.win-amd64-3.8\monai\_C.pyd : fatal error LNK1120: 2 unresolved externals error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.34.31933\\bin\\HostX86\\x64\\link.exe' failed with exit status 1120 Error: Process completed with exit code 1.

Originally posted by @myron in #5606 (comment)

@wyli
Copy link
Contributor Author

wyli commented Dec 1, 2022

@wyli wyli mentioned this issue Jan 5, 2023
7 tasks
@wyli wyli closed this as completed in #5814 Jan 6, 2023
wyli added a commit that referenced this issue Jan 6, 2023
Signed-off-by: Wenqi Li <[email protected]>

Fixes #5624 
Fixes #5816 

### Description

- undo the workaround
(29a34ad)
- smaller test case tests/test_auto3dseg_ensemble.py

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant