Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nondeterministic in HoVerNet #5609

Closed
KumoLiu opened this issue Nov 30, 2022 · 4 comments · Fixed by #5818
Closed

Nondeterministic in HoVerNet #5609

KumoLiu opened this issue Nov 30, 2022 · 4 comments · Fixed by #5818
Labels
Contribution wanted documentation Improvements or additions to documentation Feature request

Comments

@KumoLiu
Copy link
Contributor

KumoLiu commented Nov 30, 2022

In the current HoVerNet implementation of MONAI, it uses UpSample with NONTRAINABLE mode which used torch.nn.functional.interpolate() may cause nondeterministic.

MONAI/monai/networks/nets/hovernet.py

Lines 535 to 537 in d0db5fd

self.upsample = UpSample(
2, scale_factor=2, mode=UpsampleMode.NONTRAINABLE, interp_mode=InterpolateMode.BILINEAR, bias=False
)

https://pytorch.org/docs/stable/generated/torch.use_deterministic_algorithms.html#torch.use_deterministic_algorithms

Describe the solution you'd like
It may need to be explained in the docstring.
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Nov 30, 2022

cc @JHancox @drbeh, could you please double confirm it?

@JHancox
Copy link
Contributor

JHancox commented Nov 30, 2022

@KumoLiu Is this non-determinism specific to Upsample? Also, doesn't it use torch.nn.Upsample rather than torch.nn.functional.interpolate?

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Nov 30, 2022

Yes, it uses torch.nn.functional.interpolate() in torch.nn.UpSample.
https://github.com/pytorch/pytorch/blob/b136f3f310aa01a8b3c1e63dc0bfda8fd2234b06/torch/nn/modules/upsampling.py#L156

@wyli
Copy link
Contributor

wyli commented Jan 5, 2023

thanks, I'm labelling this a feature request to update the docstring for both hovernet and UpSample

@wyli wyli added the documentation Improvements or additions to documentation label Jan 5, 2023
@KumoLiu KumoLiu mentioned this issue Jan 6, 2023
Merged
7 tasks
@wyli wyli closed this as completed in #5818 Jan 6, 2023
wyli pushed a commit that referenced this issue Jan 6, 2023
@KumoLiu
update the docstring for HoVerNet and UpSample (#5818)
2c2de9e 
Signed-off-by: KumoLiu <[email protected]>

Fixes #5609.

### Description
Update the docstring for `HoVerNet` and `UpSample`.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contribution wanted documentation Improvements or additions to documentation Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update the docstring for HoVerNet and UpSample KumoLiu/MONAI
3 participants
@wyli @JHancox @KumoLiu