From 100db27f7cdb31650777ead7c22a2b910a3c9cd6 Mon Sep 17 00:00:00 2001 From: Matthias Hadlich Date: Thu, 5 Oct 2023 21:54:56 +0200 Subject: [PATCH] Signalfillempty set track_meta to True (#7089) Related to #7011. I was using the `Signalfillemptyd` (based on `Signalfillempty`) transform in monailabel and found out, it currently allows no inversion. When digging deeper I realized that SignalFillEmpty just throws away the meta information. With the simple addition of `track_meta=True` it works as expected. I hope it has no other impact, but I honestly don't know. @wyli would be cool if we can add this to MONAI 1.3.0, thanks! I can also rework `Signalfillempty` to just accept any datatype, if that would the more appropriate approach. ### Types of changes - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. Signed-off-by: Matthias Hadlich --- monai/transforms/signal/array.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monai/transforms/signal/array.py b/monai/transforms/signal/array.py index 1a7b87a774..938f42192c 100644 --- a/monai/transforms/signal/array.py +++ b/monai/transforms/signal/array.py @@ -380,7 +380,7 @@ def __call__(self, signal: NdarrayOrTensor) -> NdarrayOrTensor: Args: signal: signal to be filled """ - signal = torch.nan_to_num(convert_to_tensor(signal), nan=self.replacement) + signal = torch.nan_to_num(convert_to_tensor(signal, track_meta=True), nan=self.replacement) return signal