Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Add Spring Security #69

Open
knjk04 opened this issue Mar 1, 2021 · 9 comments
Open

Add Spring Security #69

knjk04 opened this issue Mar 1, 2021 · 9 comments
Assignees
Labels
enhancement New feature or request spring-security

Comments

@knjk04
Copy link
Member

knjk04 commented Mar 1, 2021

Add Spring security with roles ('user' and 'admin').

All queries should be accessible without being authenticated. Mutations should only be allowed for those with admin access.

@knjk04 knjk04 self-assigned this Mar 1, 2021
@knjk04 knjk04 added the enhancement New feature or request label Mar 1, 2021
@pranatimittal
Copy link

Hey, I would like to try adding user/admin roles. Can I?

@knjk04 knjk04 removed their assignment Oct 2, 2021
@knjk04 knjk04 added good first issue Good for newcomers hacktoberfest Issues to be worked on during the Hacktoberfest 2021 period labels Oct 2, 2021
@knjk04
Copy link
Member Author

knjk04 commented Oct 2, 2021

Hi @pranatimittal, sure, I'll assign you to the issue. Thanks!

@pranatimittal
Copy link

@knjk04 could you help me get started? I have never worked with dgs and spring security and interested to lean it

@machinalny
Copy link

machinalny commented Oct 4, 2021

Hey, @knjk04 How user should be authorized? Basic Auth? Bearer Token? Oauth? Maybe API Key?

@knjk04
Copy link
Member Author

knjk04 commented Oct 10, 2021

@pranatimittal For both DGS and Spring Security, but particularly DGS, I recommend looking at the official documentation. DGS is quite new, so there may be relatively few tutorials out there. They have a page on Spring security. You can also walk through the tutorials on the site to find out how it works.

For Spring Security specifically, there are lots of good tutorials online, so you can find what works best for you.

I've noticed that security comes under the advanced section in the DGS documentation, so I've removed the 'good first issue' label.

If you don't mind, I'll unassign you from this issue as it may be trickier for a beginner (although, definitely doable) than I initially thought. I'll see if there's something else for you to pick it up. It looks like @machinalny has some experience with this, so I think they'll be a better fit for this.

@knjk04
Copy link
Member Author

knjk04 commented Oct 10, 2021

Hi @machinalny, good question! API key would be great. Are you happy for me to assign you to this?

@machinalny
Copy link

Hi @knjk04, thanks! You can assign it to me, ;)

@knjk04
Copy link
Member Author

knjk04 commented Dec 15, 2021

@machinalny How are you getting on with this?

@knjk04
Copy link
Member Author

knjk04 commented Feb 5, 2022

@machinalny Unassigning due to no response

@knjk04 knjk04 removed the hacktoberfest Issues to be worked on during the Hacktoberfest 2021 period label Feb 5, 2022
@knjk04 knjk04 added this to Books API Feb 14, 2022
@knjk04 knjk04 self-assigned this Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request spring-security
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants