Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScript Implementations for Singleton and Abstract Factory Design Patterns #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mesalm
Copy link

@mesalm mesalm commented Oct 25, 2024

I have implemented the Singleton and Abstract Factory design patterns in JavaScript. I followed the same structure and methodology used throughout the project to maintain organization and consistency.

Please review the changes, and let me know if there are any adjustments needed. I'm looking forward to your feedback!

Thank you

@mesalm
Copy link
Author

mesalm commented Oct 25, 2024

If possible, could you please add the hacktoberfest label to this pull request? I would greatly appreciate it

@sunny7899
Copy link
Member

@mesalm Can you add some flow diagram to understand it better.

@mesalm
Copy link
Author

mesalm commented Oct 25, 2024

Thanks for the feedback! I’ll create flow diagrams for both the Singleton and Abstract Factory patterns to illustrate how they work. Would you prefer these diagrams to be added to the project as images in the documentation, or would you like them as a separate file for your reference?

Let me know what works best for you, and I’ll proceed accordingly.

Thank you

@mesalm
Copy link
Author

mesalm commented Oct 26, 2024

Thank you for the feedback and for adding the hacktoberfest-accepted label to the pull request! I wanted to check if there’s anything else needed on my end for this PR to be merged, or if you had any additional comments before proceeding. Please let me know if I can assist with any final changes.

Looking forward to your response, and thank you for the opportunity to contribute!
@sunny7899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Missing JavaScript Implementations for Design Patterns
2 participants