Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run failed: deploy-book #13

Closed
rvosshall opened this issue Nov 11, 2021 · 3 comments
Closed

Run failed: deploy-book #13

rvosshall opened this issue Nov 11, 2021 · 3 comments

Comments

@rvosshall
Copy link
Member

Previous requirements.txt results in the following error:

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/pydata_sphinx_theme/bootstrap_html_translator.py", line 34, in visit_table
    self._table_row_index = 0
AttributeError: can't set attribute

See also Incompatibility with sphinx 4.3.0.

Issue seems to be fixed in release 0.7.2 of pydata-sphinx, but installation of jupyterpy-book uses data-sphinx-theme-0.6.3.

Use of sphinx 4.2 yields intermediate solution.

@canbooo
Copy link
Member

canbooo commented Nov 11, 2021

Use of sphinx 4.2 yields intermediate solution.

What does this mean. Could we solve this by changing our workflow script?

@canbooo
Copy link
Member

canbooo commented Nov 11, 2021

Commit cfae9ee fixes this for now. Reopen if the incompatibility is fixed and you feel like we should use the most recent version.

@canbooo canbooo closed this as completed Nov 11, 2021
@kousu
Copy link

kousu commented Nov 11, 2021

btw as soon as the next sphinx-book-theme is released, it will use pydata-sphinx-theme-0.7.2, and that will fix this bug. And a release should be coming in a few days it sounds like!

executablebooks/sphinx-book-theme#429 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants