Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for unlink behavior of _MemoryTahoe and Tahoe is less precise than ideal #381

Open
exarkun opened this issue May 17, 2022 · 0 comments
Open

Test for unlink behavior of _MemoryTahoe and Tahoe is less precise than ideal #381

exarkun opened this issue May 17, 2022 · 0 comments

Comments

@exarkun
Copy link
Collaborator

exarkun commented May 17, 2022

test_unlink_non_directory creates a normal file immutable and then tries to unlink something from it. Tahoe.unlink fails with NotADirectoryError and _MemoryTahoe fails with NotWriteableError. Both are true so neither is strictly wrong but being consistent would be better.

Since we have no API for creating a non-directory mutable, there's no way to set up a test scenario where only NotADirectoryError would be the correct result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@exarkun