-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a metric for invalid ZKAP attempts #265
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isodate duration parser has some bugs
Let's see how far we get with just this simpler version. We now have a histogram for number of zkaps spent, bucketed by the size of individual spend operations. Also implement it for mutables
Also make the metrics path's parent directory if necessary
It's more specific and less powerful, therefore more expressive and safe. Co-authored-by: Tom Prince <[email protected]>
The test demonstrates this now by depending on part of the successful result from the underlying storage server object.
also rename and clarify the read_bucket `size` parameter
exarkun
force-pushed
the
260.metric-rejected-zkaps
branch
from
December 13, 2021 15:54
1959551
to
a509c28
Compare
Maybe a good idea but ... maybe not? No demonstrated utility yet, anyway. Also it ended up being a lot more complex than I anticipated. Maybe this is something to look into in the future but I'm closing it for now so that the list of open PRs reflects active development efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260
This does not expose the total number of ZKAPs that are considered invalid. Instead it just counts the number of operations attempted where an invalid ZKAP is observed. Maybe this will provide sufficient visibility. There is still only one way we can recognize a pass as invalid - invalid signature - so there's only one label on this metric. It should be straightforward to add more ways as we define them.