-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Birb #2542
Added support for Birb #2542
Conversation
Thank you for making this language definition @Calamity210! However, I don't know if we can merge this. Right now, the documentation for your language is too little for others to work with. Specifically for this PR, the doc is inconsistent with the Prism language definition. E.g. at no point does the doc mention triple-quote string literals and the doc explicitly states that single-quote string literals can be multiline but that isn't supported by the language definition. The lack of documentation also means that the language definition will be practically unmaintainable since we won't be able to review any patches or enhancements to the Birb language definition either. Thoughts? @Calamity210 @mAAdhaTTah |
For sure makes sense to me, the triple quotes was actually incorrect, Birb doesnt support it. Mind if I request a review from you once our docs are improved? @RunDevelopment |
Sure! (Maybe add a comment with a link to the docs to your language definition once you're finished.) |
@RunDevelopment We are still working on an api documentation, but the tour documents the complete syntax. https://birbolang.web.app/docs/ this document contains more or less everything about Birbs syntax itself as it stands right now, what exactly are you looking for with the docs? |
Prism highlights concepts (functions, classes, operators, ...), so when reading through language documentation, I'm always looking for all the concepts the language has to offer. I then go through each concept and look for its syntax (most docs do this via examples but some even give you the BNF grammar of single concepts or even the whole language). I think the doc is ok in that regard. One of the nice sides of a minimal language is that you don't need a lot of documentation to describe it. Ready for review? Also, I'm a little curious as to how Birb infers the type of a variable with
|
Yeah, lets do it!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the review.
Apart from my comment, please use tabs for indentation. There are a few lines where tabs and spaces are mixed.
Had I mixed them, i had a bit of a brainfog the day I worked on this, ill correct this along with the comments in a bit. Thanks! |
@RunDevelopment I've taken a look at the comments and corrected them. I removed the pattern I had for functions as it seemed like I was misunderstanding something. Everything else should be fine afaict. |
Looks good! To resolve the merge conflicts, run |
Yup give me one min |
Resolved @RunDevelopment |
Thank you for contributing @Calamity210! |
Added support for a custom language(Birb)