Default Theme: Add a comment that declares the background color of operator tokens as intentional
#2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
approved these changes
Jun 7, 2020
quentinvernot
pushed a commit
to TankerHQ/prismjs
that referenced
this pull request
Sep 11, 2020
…`operator` tokens as intentional (PrismJS#2309)
|
Hey, is there's a reason for this intentional background statement? |
|
The styles are entirely up to the author of the theme. They probably like the light emphasis the background color puts on operators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since people seem to somewhat regularly report and fix the background color of
operatortokens in the default theme, I added a little comment to clarify that it's indeed intentional.NGL, when I first saw Prism, I also thought it's a bug.