Scheme: Improvements #2263
Merged
Scheme: Improvements #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
reviewed
Apr 7, 2020
| // <b.o.x. number> := <b.o.x. prefix>[+-]?<b.o.x. complex> | ||
| // | ||
| // <number> := <dec number>|<b.o.x. number> | ||
| pattern: /([\s()])(?:(?:#d(?:#[ei])?|#[ei](?:#d)?)?[+-]?(?:(?:\d*\.?\d+(?:[eE][+-]?\d+)?|\d+\/\d+)(?:[+-](?:\d*\.?\d+(?:[eE][+-]?\d+)?|\d+\/\d+)i)?|(?:\d*\.?\d+(?:[eE][+-]?\d+)?|\d+\/\d+)i)|(?:#[box](?:#[ei])?|#[ei](?:#[box])?)[+-]?(?:[\da-fA-F]+(?:\/[\da-fA-F]+)?(?:[+-][\da-fA-F]+(?:\/[\da-fA-F]+)?i)?|[\da-fA-F]+(?:\/[\da-fA-F]+)?i))(?=[\s()]|$)/, |
There was a problem hiding this comment.
Honestly, I don't.
It explains the pattern by showing its simpler components, yes, but how do you know that the pattern is actually what's written there? I actually manually "generated" the pattern by substituting the rules myself, so I can tell you it's a pain... especially if you change something...
I'd rather have the pattern generated from a BNF.
We could implement a BNF-like syntax with #2190 and a syntax like this:
bnf({
// Decimal numbers
'dec real' : /\d*\.?\d+(?:[eE][+-]?\d+)?|\d+\/\d+/.source,
'dec complex' : /<dec real>(?:[+-]<dec real>i)?|<dec real>i/.source,
'dec prefix' : /(?:#d(?:#[ei])?|#[ei](?:#d)?)?/.source,
'dec number' : /<dec prefix>[+-]?<complex>/.source,
// Binary, octal, and hexadecimal numbers
'box real' : /[\da-fA-F]+(?:\/[\da-fA-F]+)?/.source,
'box complex' : /<box real>(?:[+-]<box real>i)?|<box real>i/.source,
'box prefix' : /#[box](?:#[ei])?|#[ei](?:#[box])?/.source,
'box number' : /<box prefix>[+-]?<box complex>/.source,
'out' : /<dec number>|<box number>/.source,
}); // returns a RegExpBut this has a whole range of problems associated with it one of them being that minification basically impossible.
mAAdhaTTah
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some improvements to the Scheme language in an effort to fix the remaining TODOs in #1451.