-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a Coy bug to the known failures page. #2170
Added a Coy bug to the known failures page. #2170
Conversation
Actually @RunDevelopment I discovered another Coy shadow bug, this time vertically!. If you have two flexbox items (this is very important to me to include code snippets in flexbox children!), the code snippit will only extend vertically as much as it needs, but the shadow will extend vertically to fill the flexbox! The overall problem is that you seem to be using two different approaches to sizing the code section and the shadow. It seems to be that if this keeps appearing, there's a fundamental flaw in the approach. The shadow should match the code area, both horizontally and vertically. As I mentioned before I'm going to turn the shadow off across all my pages, but it's a shame and I think you should revisit how you do the shadow. |
So we can go in both directions... At least it's consistent. But this seems to be the same bug just caused by flex(ing) this time.
There is. For Coy, the
I am curious about how you do this. Do you just disable the pseudo-elements and make the background transparent or do you actually fix the layout (if so, how)? |
I'm just following the instructions in #894 (which I opened after all the Coy shadow problems in #859). It had been so long that I had forgotten all the pain the shadows caused, and tried to turn them back on. Now they are on across all my sites and I'll have to go back and turn them off again. It will be wonderful to have the bugs publicly documented so I won't make that mistake again. |
If there's an alternate approach you have in mind, we could possibly put it in |
Thanks, but frankly this is the least of my worries at the moment. As long as I have a way to turn it off, I can concentrate on other problems. I think In any case the most important thing for the short terms is to document the problems in a visible way and explain how to turn the shadows off. |
I haven't tried it in a while. When I last tried it I was using an old version of Prism. I just assumed it still worked. If not we have a bigger problem. If it doesn't work then maybe you should provide a version of Coy after all that uses the same technique as the other themes but without the shadow. |
I think the Coy theme always overlapped other elements, correct? That's why usually I would float the Prism block e.g. to the left if I had something I wanted it to wrap around. This problem with the shadow is not that the code block overlapped with a float (because that always happened, unfortunately), but that the shadow didn't match up with the code block dimensions and therefore didn't look like a shadow. |
I can't say 100%, but I'm pretty sure that two or three years ago the overlap would occur but the code would also extend to fill that white space! So did something change in the past couple of years? If as you say the |
See, look at #866. I'm pretty sure that the Coy theme would reach right through the float. Why doesn't it work that way anymore? One could argue that this is the correct behavior, even though I don't like it. |
In fact #866 wouldn't be so bad if I could change the Z order somehow and have my floats go on top of Prism. |
As discussed here.
I also quickly looked for other open theme issue but couldn't find any. If there are any I missed, please leave a comment.