improve typescript with builtins and add tsx #1277
Conversation
There was a problem hiding this comment.
Hi! Thanks for contributing.
Though I think this should rather be divided into two PRs.
Could you please take a look at my comments?
Also, could you add an example file for TSX, following the format used in existing examples?
components.js
Outdated
| @@ -578,6 +578,10 @@ var components = { | |||
| "require": "markup", | |||
| "owner": "Golmote" | |||
| }, | |||
| "tsx": { | |||
| "title": "React Tsx", | |||
| "require": ["markup", "javascript", "jsx", "typescript"] | |||
There was a problem hiding this comment.
I think there is no need to require markup and javascript here, since they are already requirements for jsx.
There was a problem hiding this comment.
Also, could you please move the component up so that the alphabetical order is based on the title value instead of the key. I know this is kinda counter-intuitive, but it's the way we did with JSX, so let's keep it consistent.
|
Ok, I'll remove the tsx stuff from this one and a separate PR for that! 👍 |
fyrkant
force-pushed
the
typescript-improvements
branch
from
078a5fc to
357b1e4
Compare
|
Removed tsx from this one and opened up a new PR with only tsx! |
|
Thanks for contributing! |
Improved typescript with some builtins and added tsx.