Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design // sharper card images when enlarged #663

Open
jkotin opened this issue Jun 8, 2020 · 3 comments
Open

Design // sharper card images when enlarged #663

jkotin opened this issue Jun 8, 2020 · 3 comments
Labels

Comments

@jkotin
Copy link

jkotin commented Jun 8, 2020

Not urgent, minor issue, but I think the quality of the card image should be better when enlarged. As it stands they are a little "hazy" / not-quite-sharp. If this is a tricky fix or would slow down the site significantly, forget it. Here's an example:

https://shakespeareandco.princeton.edu/members/dalsace/cards/4e22c3aa-eca5-4f3a-8ca2-f60590183995/#zoom

@rlskoeser
Copy link
Contributor

@jkotin that image looks clear to me. Can you share a screenshot and also document what device or screen size you're using when you see this? Two main things that are relevant: whether or not you're on a retina-style screen (in which case you get a 2x image) and how wide your browser screen or device is.

@jkotin
Copy link
Author

jkotin commented Jun 11, 2020

@rlskoeser -- I'm on MacBook Pro (15-inch, 2019) -- I usually use Firefox or Safari. Here's a screenshot. I may be noticing
Screen Shot 2020-06-11 at 3 07 32 PM
the issue, in part, because I'm used to looking at the actual cards and the digitized cards in the finding aid. To my eyes, the enlarged cards lack definition, sharpness.

@gissoo
Copy link
Contributor

gissoo commented Jun 23, 2020

@jkotin, @rlskoeser and I conversed on this and I tested it this morning.
I looked at the exact same page you have above live from the site using my macbook 15in 2019 retina display and it exactly matches your screenshot. Here it is:
Screen Shot 2020-06-23 at 10 03 27 AM

However, when I also looked your screenshot and my live version on my monitor (Dell), my live version is slightly sharper. Here it is: (might be hard to tell the difference as it's a small difference)
Screen Shot 2020-06-23 at 9 58 18 AM

Note: I did the test on all browsers (FF, Chrome, and Safari)
This being said, I think it makes sense to increase the image quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants