Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-populate flow group schedules when editing #989

Merged
merged 6 commits into from
Aug 10, 2021

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Auto-populates schedules when modifying previously created ones. Also retunes the weekly interval schedule to make more sense and fixes a bug where it wasn't creating a schedule with the correct interval.

Resolves #838

@zhen0
Copy link
Member

zhen0 commented Aug 9, 2021

@ThatGalNatalie - could you take a look at this one? Thank you!

ThatGalNatalie
ThatGalNatalie previously approved these changes Aug 9, 2021
Copy link
Contributor

@ThatGalNatalie ThatGalNatalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

zhen0
zhen0 previously approved these changes Aug 10, 2021
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also @znicholasbrown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing a schedule doesn't pre-fill the schedule form
3 participants