Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host config to the docker run config #988

Merged
merged 8 commits into from
Aug 10, 2021
Merged

Add host config to the docker run config #988

merged 8 commits into from
Aug 10, 2021

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Adds the host_config field to the static run config options.

Resolves #977

@znicholasbrown znicholasbrown mentioned this pull request Aug 6, 2021
Closed
zhen0
zhen0 requested changes Aug 10, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and one small change @znicholasbrown

Changelog.md Outdated Show resolved Hide resolved
src/utils/runConfigs.js Outdated Show resolved Hide resolved
zhen0
zhen0 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @znicholasbrown

@znicholasbrown znicholasbrown merged commit d8543cc into master Aug 10, 2021
@znicholasbrown znicholasbrown deleted the docker-host-config-fix branch August 10, 2021 18:03
@znicholasbrown znicholasbrown mentioned this pull request Aug 17, 2021
Merged
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhen0 zhen0 zhen0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking "Show advanced run configuration" in Prefect UI erases RunConfig.host_config
2 participants
@znicholasbrown @zhen0