Separate primary and secondary Apollo client links #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znicholasbrown
changed the title
|
Apologies for review taking a while - as background, I don't think connected to the PR, but I'm having trouble getting server to run locally when I review this. |
zhen0
previously approved these changes
Aug 10, 2021
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR
This PR removes the Batch link from the secondary Apollo client, which is used for non-component-based API requests (like auth, api status, etc). This results in significant improvements in load time (up to 40% faster over the current setup) due to these requests no longer needing to wait for the batch interval to complete.
I've also increased the batch interval for the primary Apollo client to 2 seconds (up from 1 second) and increased the batch size to 25 (up from 20). Overall this should have very little visible impact on load times but will offset any potential increase in requests from the secondary client.