Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logrocket initialization to its own plugin #940

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Move logrocket initialization to its own plugin #940

merged 4 commits into from
Jul 8, 2021

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Moves logrocket to its own plugin and initializes it outside of application startup, allowing us to better diagnose startup issues

zhen0
zhen0 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @znicholasbrown

@znicholasbrown znicholasbrown merged commit eeeb32e into master Jul 8, 2021
@znicholasbrown znicholasbrown deleted the better-logging branch July 8, 2021 13:49
@znicholasbrown znicholasbrown mentioned this pull request Jul 13, 2021
Merged
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhen0 zhen0 zhen0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@znicholasbrown @zhen0