Flow Run Cancellation #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhen0
requested changes
Aug 10, 2020
|
Ok made those updates @zhen0 - we'll limit this to Core 0.13.0. |
zhen0
requested changes
Aug 10, 2020
src/components/CancelButton.vue
Outdated
| Upgrade your flow to Prefect 7.3 or higher to enable cancellation. | ||
| Your Flow was registered with version {{ flowRun.flow.core_version }} of | ||
| Prefect Core; please upgrade to version 0.13.0 or higher and re-register | ||
| your Flow to enable cancellation. | ||
| </span> | ||
| <span v-else-if="flowRun.state !== 'Running'"> |
There was a problem hiding this comment.
Do we still want this? I can imagine cases where it might be useful to cancel from a scheduled or submitted flow run?
There was a problem hiding this comment.
I think opening this up isn't a bad idea, let's do it.
There was a problem hiding this comment.
Ok - updated to allow cancellation when in a non-finished state.
Co-authored-by: Jenny G <[email protected]>
…hen a flow run is in a finished state
cicdw
reviewed
Aug 10, 2020
cicdw
reviewed
Aug 10, 2020
znicholasbrown
commented
Aug 10, 2020
cicdw
reviewed
Aug 10, 2020
znicholasbrown
commented
Aug 11, 2020
zhen0
approved these changes
Aug 11, 2020
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR
Adds a cancellation button to the flow run actions bar too allow cancelling of in-progress runs.