Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check on all permissions that bypasses the license for Server #912

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Add a check on all permissions that bypasses the license for Server #912

merged 4 commits into from
Jun 23, 2021

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

This introduces a permissions bypass for Server, which doesn't have permissions.

@znicholasbrown znicholasbrown changed the title Add a check on all permisions that bypasses the license for Server Add a check on all permissions that bypasses the license for Server Jun 23, 2021
ThatGalNatalie
ThatGalNatalie approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@ThatGalNatalie ThatGalNatalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@znicholasbrown znicholasbrown merged commit 7c55296 into master Jun 23, 2021
@znicholasbrown znicholasbrown deleted the server-permissions-bypass branch June 23, 2021 18:17
@znicholasbrown znicholasbrown mentioned this pull request Jun 23, 2021
Merged
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThatGalNatalie ThatGalNatalie ThatGalNatalie approved these changes

@zhen0 zhen0 Awaiting requested review from zhen0 zhen0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@znicholasbrown @ThatGalNatalie