Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

members and service account permissions and formatting #908

Merged
merged 15 commits into from
Jun 23, 2021
Merged

members and service account permissions and formatting #908

merged 15 commits into from
Jun 23, 2021

Conversation

ThatGalNatalie
Copy link
Contributor

@ThatGalNatalie ThatGalNatalie commented Jun 22, 2021 •
edited
Loading

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

This checks for permissions on the members and service account pages as well as formats the roles

@ThatGalNatalie ThatGalNatalie marked this pull request as ready for review June 23, 2021 00:58
@ThatGalNatalie ThatGalNatalie mentioned this pull request Jun 23, 2021
Merged
2 tasks
@ThatGalNatalie ThatGalNatalie changed the title permissions and formatting members and service account permissions and formatting Jun 23, 2021
zhen0
zhen0 previously requested changes Jun 23, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main comment is (as we discussed) permission checks can be more granular. Check in local and the error handling and refetching look much better.

src/pages/TeamSettings/Members/Members-Table.vue Outdated Show resolved Hide resolved
znicholasbrown
znicholasbrown previously requested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments in addition to @zhen0's. I think we need to introduce a bypass in Server for all permissions but I can introduce that in another PR

src/pages/TeamSettings/Members.vue Outdated Show resolved Hide resolved
src/pages/TeamSettings/Members/Members-Table.vue Outdated Show resolved Hide resolved
@ThatGalNatalie ThatGalNatalie dismissed stale reviews from zhen0 and znicholasbrown June 23, 2021 15:43

changes made

znicholasbrown
znicholasbrown approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @ThatGalNatalie - LGTM

@znicholasbrown znicholasbrown merged commit e2097e8 into master Jun 23, 2021
@znicholasbrown znicholasbrown deleted the permission-audit branch June 23, 2021 18:28
@stackoverfloweth stackoverfloweth mentioned this pull request Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholasbrown znicholasbrown znicholasbrown approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@jlowin jlowin Awaiting requested review from jlowin jlowin is a code owner

@zhen0 zhen0 Awaiting requested review from zhen0 zhen0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThatGalNatalie @znicholasbrown @zhen0