Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Agents on Server #901

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Improve Agents on Server #901

merged 4 commits into from
Jun 21, 2021

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Jun 18, 2021 •
edited
Loading

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

  • Improves agent tile for Server by not showing config option and skipping the hook query if not on cloud
  • Uses hours instead of minutes for unhealthy threshold on dashboard

znicholasbrown
znicholasbrown approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@znicholasbrown znicholasbrown merged commit c7fc0d0 into master Jun 21, 2021
@znicholasbrown znicholasbrown deleted the hours branch June 21, 2021 16:30
@znicholasbrown znicholasbrown mentioned this pull request Jun 23, 2021
Merged
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholasbrown znicholasbrown znicholasbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhen0 @znicholasbrown