Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of the quick run button #846

Merged
merged 8 commits into from
May 24, 2021

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

This PR removes the automatic routing of the quick run button and introduces a new toast system for stackable global toasts with a straightforward CRUD system. It should now be a lot easier to create a bunch of runs with default parameters!

Screen.Recording.2021-05-18.at.5.02.28.PM.mov

@zanieb
Copy link
Contributor

zanieb commented May 19, 2021

Sweet. I hit this exact pain point just a couple days ago.

Copy link
Contributor

@ThatGalNatalie ThatGalNatalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good @znicholasbrown - one comment about error messages.

src/pages/Flow/Actions.vue Show resolved Hide resolved
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@znicholasbrown znicholasbrown merged commit e1c58d3 into master May 24, 2021
@znicholasbrown znicholasbrown deleted the quick-run-enhanement branch May 24, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants