-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow editing in json editor for checked params #787
Conversation
Having trouble looking in Netlify but the code makes sense to me! |
This addresses the issue it was asked to nicely but I fear that the JSON edit experience could still lead to mistakes. If I go to the schedule parameters tab and immediately switch into JSON, add my parameters and then switch back to set the schedule, I'd miss that I need to check the box to include my parameters. Could we add a JSON edit specific warning? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this fixes the issue @ThatGalNatalie - thanks. However, I think we risk wiping all a user's JSON input. Can we add a warning that they also need to check the boxes? Or remove the need to check boxes?
Previews enabled for this PR 👍 |
…e parameters on the clock
update: However, if you check a parameter then it will be added to the jsoninput but if you decide to uncheck a parameter it will not be reflected in the json editor. I think it has something to do with the Tested the run page briefly and it seems to not be affected by this change but will need to do a more thorough test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 suggestions which I think should fix the issue you're seeing
Co-authored-by: Nicholas Brown <[email protected]>
…n editor and assign those keys/values Co-authored-by: Nicholas Brown <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion
update changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @ThatGalNatalie 👍
PR Checklist:
CHANGELOG.md
Describe this PR
The JSON editor wasn't reflecting the checked/unchecked parameters. When modifying an existing schedule, the checked parameters should now be the only parameters that is displayed