Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to onboarding #721

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Small fixes to onboarding #721

merged 2 commits into from
Apr 2, 2021

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Fixes 2 issues:

  • sometimes the full animation for the team name screen wasn't playing, leading to an incorrect y-offset on the form
  • we weren't doing a full redirect of the page after license creation, which meant the cache was holding a null-license

…age, always do full redirect on the license creation to make sure the license is refreshed
Copy link
Contributor

@ThatGalNatalie ThatGalNatalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants