Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete entire flow group with new mutation #689

Merged
merged 5 commits into from
Mar 24, 2021
Merged

Conversation

whimsicallyson
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Remove (confusing) ability to delete individual flow versions, replace deleting flow group with new delete_flow_group mutation. Solves #686

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a benefit at this time to removing the ability to delete a single version -- it's possible some users have relied on this for deleting really old versions. I would prefer if we kept the original logic, but for the "delete all versions" we call this new route instead, at least until we actually remove versions in the backend

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @whimsicallyson - just 1 comment!

src/components/DeleteFlowButton.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @whimsicallyson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants